Skip to content

plugins.twitch: fix --twitch-disable-reruns #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2020
Merged

plugins.twitch: fix --twitch-disable-reruns #3375

merged 1 commit into from
Nov 28, 2020

Conversation

back-to
Copy link
Collaborator

@back-to back-to commented Nov 28, 2020

closes #3257

@back-to back-to added the plugin issue A Plugin does not work correctly label Nov 28, 2020
bastimeyer
bastimeyer reviewed Nov 28, 2020
View reviewed changes
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me add some of the tests back before merging this. Just mocking the self.api.stream_rerun call is enough, I guess. Will do this later today when I have the time.

@back-to @bastimeyer
plugins.twitch: fix --twitch-disable-reruns
f7ae527 
Co-authored-by: bastimeyer <mail@bastimeyer.de>
@bastimeyer
Copy link
Member

Are you okay with these changes, @back-to ?

@back-to back-to merged commit c8d29f7 into streamlink:master Nov 28, 2020
@back-to back-to deleted the twitch_reruns branch November 28, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastimeyer bastimeyer bastimeyer left review comments

Assignees
No one assigned
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Twitch: Detection of reruns no longer working
2 participants
@back-to @bastimeyer