plugin.api: remove support_plugin #3398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #3366,
plugin.api.support_pluginhas never been used in the main Streamlink codebase and is therefore unnecessary to keep. It's a rather ugly way of using shared plugin code, especially because it modifiessys.moduleswith a dynamic module loading system based on the call stack of the importing module. This PR thus removes thesupport_pluginAPI, which is a breaking change and should be included in 2.0.0.There's also the
streamlink.plugin.api.httpvariable which gets removed by this PR.It should have already been removed by #3366, as the overhauled plugin import system doesn't set the global HTTPSession instance anymore (technically another breaking change):
https://github.com/streamlink/streamlink/pull/3366/files#diff-6aad4096b88711d014b62443f4856dfed3bc2dab52e74822c62dae35e442da4bL448