cli.output: replace MPV player title parameter #3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace MPV's `--title` parameter with `--force-media-title`, as it also changes the name of the playlist item and not just the window title.
|
Hmm, do we have to consider this a breaking change? I don't think so since it's only when the title is not set, but it could be problematic if anyone is hooking in. |
No, this doesn't change anything Streamlink related. User-provided player args get appended to the player args list/string, so there's nothing to worry about here. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace MPV's
--titleparameter with--force-media-title, as it alsochanges the name of the playlist item and not just the window title.
See #3231 (comment)
Also changed the content of some test assertions in one go, as they were not testing the entire player argument logic (
subprocess.list2cmdlineon Windows).