cli.output: fix named pipe player input on Windows #3619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
cli/output/fix-named-pipe-player-input-on-windows
branch
from
994d7c1 to
8072b0a
Compare
|
Any chance for a quick review? I'd like to get this merged, so that this is off the to-do list for 2.1.0. |
|
Sorry @bastimeyer, busy week. This looks good. |
bastimeyer
deleted the
cli/output/fix-named-pipe-player-input-on-windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3568
Originally I had intended to refactor the NamedPipe class and a little bit of the PlayerOutput class as well, but I ran into some other issues which I haven't resolved yet, so here's a simple fix for #3568. I could refactor NamedPipe and keep the same logic as it is right now, but it's not really worth it. A proper implementation will require a complete rewrite of the PlayerOutput as well, and that's a bit much now.
Also, as mentioned in #3568, the named pipe currently doesn't get cleaned up properly if the player fails to start, which I also wanted to fix with my code refactoring.