plugins.youtube: add html5=1 parameter #3732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bastimeyer
approved these changes
May 19, 2021
There was a problem hiding this comment.
Thanks. I can confirm that this solves the problem, at least with the video ID posted in #3724.
current master
$ streamlink -l debug 'youtube.com/watch?v=yZ7CWjuMCe8' best
[cli][debug] OS: Linux-5.12.4-2-git-x86_64-with-glibc2.33
[cli][debug] Python: 3.9.5
[cli][debug] Streamlink: 2.1.1+16.g034173d
[cli][debug] Requests(2.25.1), Socks(1.7.1), Websocket(0.58.0)
[cli][debug] Arguments:
[cli][debug] url=youtube.com/watch?v=yZ7CWjuMCe8
[cli][debug] stream=['best']
[cli][debug] --loglevel=debug
[cli][debug] --player=mpv
[cli][info] Found matching plugin youtube for URL youtube.com/watch?v=yZ7CWjuMCe8
[plugins.youtube][debug] Video ID from URL
[plugins.youtube][debug] Using video ID: yZ7CWjuMCe8
error: Unable to open URL: https://youtube.com/get_video_info (404 Client Error: Not Found for url: https://www.youtube.com/get_video_info?video_id=yZ7CWjuMCe8&el=detailpage)
this PR
$ streamlink -l debug 'youtube.com/watch?v=yZ7CWjuMCe8' best
[cli][debug] OS: Linux-5.12.4-2-git-x86_64-with-glibc2.33
[cli][debug] Python: 3.9.5
[cli][debug] Streamlink: 2.1.1+17.g105cc24
[cli][debug] Requests(2.25.1), Socks(1.7.1), Websocket(0.58.0)
[cli][debug] Arguments:
[cli][debug] url=youtube.com/watch?v=yZ7CWjuMCe8
[cli][debug] stream=['best']
[cli][debug] --loglevel=debug
[cli][debug] --player=mpv
[cli][info] Found matching plugin youtube for URL youtube.com/watch?v=yZ7CWjuMCe8
[plugins.youtube][debug] Video ID from URL
[plugins.youtube][debug] Using video ID: yZ7CWjuMCe8
[plugins.youtube][debug] get_video_info - 1: Found data
[plugins.youtube][debug] MuxedStream: v 299 a 251 = 1080p60
[plugins.youtube][debug] MuxedStream: v 302 a 251 = 720p60
[plugins.youtube][debug] MuxedStream: v 135 a 251 = 480p
[plugins.youtube][debug] MuxedStream: v 133 a 251 = 240p
[plugins.youtube][debug] MuxedStream: v 160 a 251 = 144p
[cli][info] Available streams: audio_mp4a, audio_opus, 144p (worst), 240p, 360p, 480p, 720p, 720p60, 1080p60 (best)
[cli][info] Opening stream: 1080p60 (muxed-stream)
[stream.ffmpegmux][debug] Opening http substream
[stream.ffmpegmux][debug] Opening http substream
[utils.named_pipe][info] Creating pipe streamlinkpipe-93906-1-8141
[utils.named_pipe][info] Creating pipe streamlinkpipe-93906-2-5957
[stream.ffmpegmux][debug] ffmpeg command: ffmpeg -nostats -y -i /tmp/streamlinkpipe-93906-1-8141 -i /tmp/streamlinkpipe-93906-2-5957 -c:v copy -c:a copy -map 0 -map 1 -f matroska pipe:1
[stream.ffmpegmux][debug] Starting copy to pipe: /tmp/streamlinkpipe-93906-1-8141
[stream.ffmpegmux][debug] Starting copy to pipe: /tmp/streamlinkpipe-93906-2-5957
[cli][debug] Pre-buffering 8192 bytes
[cli][info] Starting player: mpv
[cli.output][debug] Opening subprocess: mpv --force-media-title=youtube.com/watch?v=yZ7CWjuMCe8 -
[cli][debug] Writing stream to output
[cli][info] Player closed
[stream.ffmpegmux][debug] Closing ffmpeg thread
[stream.ffmpegmux][debug] Pipe copy complete: /tmp/streamlinkpipe-93906-1-8141
[stream.ffmpegmux][error] Pipe copy aborted: /tmp/streamlinkpipe-93906-2-5957
[stream.ffmpegmux][debug] Closed all the substreams
[cli][info] Stream ended
[cli][info] Closing currently open stream...
If nobody has any further comments, I'm going to merge this a bit later today.
bastimeyer
added
PR: needs commit message fix
PR: squash commits
|
Thanks for the test. I hope it will be the definitive solution. |
bastimeyer
changed the title
|
Seems like this particular issue is widespread enough to possibly push out a release for?
…Sent from my iPhone
On May 19, 2021, at 2:04 PM, Sebastian Meyer ***@***.***> wrote:
Merged #3732<#3732> into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#3732 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AR6YJPN6EKOLVRKAXJ2IPTTTOP4TDANCNFSM45ES3ERA>.
|
|
Yes, we can do that. I will open a PR with a changelog for a new patch release tomorrow. |
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
May 20, 2021
and avoid 404 Client Error: Unable to open URL: https://youtube.com/get_video_info
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
Sep 30, 2021
and avoid 404 Client Error: Unable to open URL: https://youtube.com/get_video_info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3724
I have been using streamlink for more than 1 year and recording Youtube live streams. I started to have the same problem as of May 14, 2021. The PR I posted seems to solve the problem.