plugins.onetv: split plugin #3743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back-to
added
plugin issue
bastimeyer
reviewed
May 23, 2021
Comment on lines
+14
to
+24
| _re_url_1 = re.compile(r'https?://(?P<channel>ctc(?:love)?|chetv|domashniy|5-tv)\.ru/(?:online|live)') | ||
| _re_url_2 = re.compile(r'https?://(?P<channel>ren)\.tv/live') | ||
| _re_url_3 = re.compile(r'https?://player\.mediavitrina\.ru/(?P<channel>[^/?]+.)(?:/[^/]+)?/[\w_]+/player\.html') | ||
|
|
||
| @classmethod | ||
| def can_handle_url(cls, url): | ||
| return ( | ||
| cls._re_url_1.match(url) is not None | ||
| or cls._re_url_2.match(url) is not None | ||
| or cls._re_url_3.match(url) is not None | ||
| ) |
There was a problem hiding this comment.
Not sure if this should be changed to a single regex.
If we ever switch the plugin matching system and load plugins on demand with a list of regexes extracted from the plugin modules during build time, then we need to implement a system that can take multiple regexes into account for a single plugin. There are only a handful of plugins currently (5 or so) that use "extended" logic in the can_handle_url method.
Shouldn't be too much of an issue though, so feel free to ignore.
- remove broken VOD support - remove other domains which use API V2, 1TV uses API V1
- re-added removed domains from onetv plugin
bastimeyer
approved these changes
May 24, 2021
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
May 27, 2021
- remove broken VOD support - remove other domains which use API V2, 1TV uses API V1
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
May 27, 2021
- re-added removed domains from onetv plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugins.onetv
plugins.mediavitrina
closes #3587
closes #3669