stream.hls: remove hls-segment-stream-data option #3894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back-to
reviewed
Jul 31, 2021
- always stream data from unencrypted segment downloads - never stream data from cached initialization sections, as the response content can only be consumed once when stream=True - update --twitch-low-latency plugin argument and its description
bastimeyer
force-pushed
the
session/remove-hls-segment-stream-data
branch
from
6fe0d58 to
1f0b987
Compare
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Aug 1, 2021
…#3894) - always stream data from unencrypted segment downloads - never stream data from cached initialization sections, as the response content can only be consumed once when stream=True - update --twitch-low-latency plugin argument and its description
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
response content can only be consumed once when stream=True
This also fixes a bug with the previous media initialization sections (segment maps) implementation, which raises an exception when stream is set to True, as the content can only be consumed once when iterating and writing chunks to the buffer.