session: move from http to https as default scheme #4068
Conversation
Apply the https scheme to all input URLs if the scheme is missing: - session: - Session.resolve_url() - session option `http-proxy` (`--http-proxy` CLI argument) - plugins.akamaihd: `akamaihd://URL` - plugins.dash: `dash://URL` or `URL.mpd` - plugins.hds: `hds://URL` or `URL.f4m` - plugins.hls: `hls://URL` or `URL.m3u8` - plugins.http: `httpstream://URL` Regular http URLs (non-https/TLS) will need to be set explicitly now. Also - update/fix test_session - refactor/fix test_dash - refactor/fix test_stream
bastimeyer
force-pushed
the
session/https-as-default
branch
from
bbf80ed to
fd33e2b
Compare
|
As much as I hate to say it I do think we should consider this a breaking change. I don't see any reason not to merge this or to delay though, we have no obligation to avoid introducing breaking changes. If a site doesn't support HTTPS they're not worth supporting so I don't care if we break those sites. |
|
We're not breaking sites/plugins, we're breaking user inputs. Anything non-https does still work if I would've preferred waiting a bit before merging, but it's too late now. Since this is a breaking change, we should see what we can include in the next release that will be a breaking change as well, to avoid having lots of unnecessary major version bumps. It doesn't have to be everything marked as deprecated though (considering the time of the deprecation) |
|
@bastimeyer My bad I didn't realize from the tone of your comment that you wanted to wait and thought you were noting it was a breaking change that should be merged any way. |
…k#4068) Apply the https scheme to all input URLs if the scheme is missing: - session: - Session.resolve_url() - session option `http-proxy` (`--http-proxy` CLI argument) - plugins.akamaihd: `akamaihd://URL` - plugins.dash: `dash://URL` or `URL.mpd` - plugins.hds: `hds://URL` or `URL.f4m` - plugins.hls: `hls://URL` or `URL.m3u8` - plugins.http: `httpstream://URL` Regular http URLs (non-https/TLS) will need to be set explicitly now. Also - update/fix test_session - refactor/fix test_dash - refactor/fix test_stream
Apply the https scheme to all input URLs if the scheme is missing:
http-proxy(--http-proxyCLI argument)akamaihd://URLdash://URLorURL.mpdhds://URLorURL.f4mhls://URLorURL.m3u8httpstream://URLRegular http URLs (non-https/TLS) will need to be set explicitly now.
Also
Resolves #4047
Follow-up of #4053
This changes the way user input is handled. In almost all cases, this simply avoids the initial insecure http request when no scheme was defined, which then gets redirected by the server to a secure connection, so no breaking change here. For sites though which don't support https/TLS, setting the http scheme is now mandatory, which is the reason why I'm not sure if this is a breaking change. It probably is...
http-proxyoption make sense?If we change the stream URL input, then we should change this too, IMO.
Also, having two separate options for http and https is stupid and we should merge this at some point.