Skip to content

plugins.tga: remove plugin #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

bastimeyer
Copy link
Member

I am not 100% sure if this site is still operating or if it's just an issue on my side because I can't access it. There seems to be content, but it could also be fake, which is not too uncommon.

See my comment from #4040:
#4040 (comment)

  • this plugin was once meant for "Tencent's Gaming Platform TGA", but it went offline in favor of longzhu.com
  • according to the few results on google, longzhu.com is the orga of an esports team which was founded in 2015 and was then bought/dissolved in 2016
  • "Tencent Gaming Platform" was discontinued in favor of "WeGame" in 2017 according to wikipedia
  • longzhu.com is failing to load any kinds of assets except images, on both http and https, regardless whether an IP from or outside of China is being used
  • streams are not loading
  • the plugin hasn't been maintained in years, has a broken URL matcher and would require a complete rewrite
  • it has only been modified once (in 2018) with a miniscule change after the streamlink fork
  • docs are outdated/incorrect

Full commit history:
https://github.com/streamlink/streamlink/commits/98428d663e1cac084c4597419445042e6a81f9fd/src/streamlink/plugins/tga.py

We could just remove the RTMPStream import and call it a day, but I don't see the point keeping the plugin if it's unmaintained.

@gravyboat
Copy link
Member

Let's get rid of the plugin. If someone wants it back we can discuss it at that point, it would need to be completely reworked any way.

@gravyboat gravyboat merged commit bbdb5fc into streamlink:master Oct 31, 2021
@bastimeyer bastimeyer deleted the plugins/tga/remove branch October 31, 2021 03:17
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants