plugins.nicolive: re-implement plugin #4155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4153
send_watching
method and the dedicated scheduler thread. Thewatchinginterval
command doesn't seem to be sent anymore on their website, so I dropped thewatching
message stuff entirely. It also tried reading theself.broadcast_id
attribute which didn't exist in the plugin, meaning it was sending thewatching
command without any data.currentstream
command on thewatch
response type doesn't seem to exist anymore either. This looked like a second response type for getting the HLS stream URL.{"protocol": "hls+fmp4", "latency": "low"}
parameters. I didn't change it because I'm not sure if it's supported everywhere. If it is, then this change is trivial and can be done later.streamlink_cli
as it immediately terminates, I've added logic for closing the websocket thread gracefully when no stream gets opened after a short while (for listing stream qualities via the API). This means there's a double Event.wait call here, one for acquiring the HLS URL on the main thread and one for opening the stream on the websocket thread.I'm not 100% confident with these changes, so please only merge if fully reviewed and tested.