Skip to content

streams: remove HDS/AkamaiHD and flashmedia pkg #4168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

bastimeyer
Copy link
Member

  • drop HDS and AkamaiHD stream implementations
  • drop HDS and AkamaiHD plugins
  • drop streamlink.packages.flashmedia
  • remove stream.flvconcat, stream.playlist and plugins.common_swf
  • remove "hds" from default stream types list
  • remove all --hds-* CLI arguments and hds-* session options
  • remove unneeded flashmedia license text files
  • update tests
  • update docs and CLI argument help texts

ref #4040

Should this be done in one commit or does this need to be split up into multiple commits?

This PR intentionally doesn't include RTMP stuff, because it's not 100% certain yet whether we want to remove it too, and it would also require some more changes related to rtmpdump, documentation, etc, which I think should definitely be done separately.

- drop HDS and AkamaiHD stream implementations
- drop HDS and AkamaiHD plugins
- drop streamlink.packages.flashmedia
- remove stream.flvconcat, stream.playlist and plugins.common_swf
- remove "hds" from default stream types list
- remove all `--hds-*` CLI arguments and `hds-*` session options
- remove unneeded flashmedia license text files
- update tests
- update docs and CLI argument help texts
Copy link
Member

@gravyboat gravyboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be done in one commit or does this need to be split up into multiple commits?

I'm fine with one. Let's see what others think.

@back-to
Copy link
Collaborator

back-to commented Nov 12, 2021

This PR intentionally doesn't include RTMP stuff, because it's not 100% certain yet whether we want to remove it too

probably yes

@back-to back-to merged commit 46817a1 into streamlink:master Nov 12, 2021
@bastimeyer bastimeyer deleted the remove-flashmedia branch November 12, 2021 19:18
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Nov 15, 2021
based on streamlink#4168

- drop HDS and AkamaiHD stream implementations
- drop HDS and AkamaiHD plugins
- remove stream.playlist and plugins.common_swf
- remove "hds" from default stream types list
- remove all `--hds-*` CLI arguments and `hds-*` session options
- update tests
- update docs and CLI argument help texts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants