utils.parse: fix encoding in parse_html #4201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Nov 23, 2021
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the character encoding in parsed HTML documents. This should've been caught way sooner.
lxml's XML parser requires bytes as input, hence why strings must be encoded to bytes first (default utf8 encoding). The content is then decoded and parsed correctly as utf8 regardless whether the XML declaration with the document's encoding is missing or not.
The HTML parser on the other hand treats byte inputs differently, but only when the
<meta charset="utf8">tag is missing in the first X bytes of the document. So if we encode input strings here to bytes as well (default utf8 encoding) and if the tag is missing too, then this will lead to decoding errors, as the parser won't treat the input as utf8 encoded data.See the added tests.