Skip to content

plugins: add missing "description" metadata tags #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2022
Merged

plugins: add missing "description" metadata tags #4391

merged 1 commit into from
Mar 12, 2022

Conversation

mkbloke
Copy link
Member

@mkbloke mkbloke commented Mar 11, 2022

closes #4383

@bastimeyer
Copy link
Member

Thanks for putting in all the effort and researching this. I will review this properly later.

One mistake I noticed while quickly going through the list were the descriptions of ard_live and ard_mediathek at the top. It's the same TV channel, "ARD".

back-to
back-to reviewed Mar 12, 2022
View reviewed changes
bastimeyer
bastimeyer reviewed Mar 12, 2022
View reviewed changes
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions and corrections, in addition to what @back-to already reviewed.

bastimeyer
bastimeyer reviewed Mar 12, 2022
View reviewed changes
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be good now. In case someone else wants to (re-)review, I'm leaving this PR open for another bit.

Thanks again for the work, @mkbloke. 👍

Btw, should we add another attribute to the metadata? Like for example what kind of streams the plugins return and whether FFmpeg is a requirement? This could probably be automated by checking the imports though.

gravyboat
gravyboat approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@gravyboat gravyboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, thanks @mkbloke!

@back-to back-to merged commit 90230e4 into streamlink:master Mar 12, 2022
@mkbloke mkbloke deleted the plugin-desc branch March 12, 2022 21:47
@mkbloke mkbloke mentioned this pull request Mar 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@back-to back-to back-to left review comments

@bastimeyer bastimeyer bastimeyer approved these changes

@gravyboat gravyboat gravyboat approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugins: add missing "description" metadata tags
4 participants
@mkbloke @bastimeyer @gravyboat @back-to