plugins.mdstrm: new plugin for mdstrm.com livestreams #4395
Conversation
|
It works here with no problems. Thank you @back-to ! |
There was a problem hiding this comment.
The plugin implementation is looking fine and should be good to be merged apart from the missing metadata.
I'm not a fan of the trailing closing parenthesis and indentation style though which makes it unnecessarily more difficult to read and edit later on for the sake of being more compact. I don't want to complain, but if we decide to add a more strict linting config in the future (like python-black for example), then this will most certainly generate unnecessary diffs. For now this is valid coding style though.
| validate.any(None, str)) | ||
| error_msg = validate.validate(schema, root) | ||
| if error_msg: | ||
| log.error(f"{error_msg}") |
There was a problem hiding this comment.
Is this intentional that there's no return statement here? If the content is unavailable / geo-blocked, then it should stop here (I guess), because otherwise it'll log
[plugins.mdstrm][debug] Failed to find window.MDSTRM.OPTIONS
There was a problem hiding this comment.
it is intended,
i don't know if ".//div[@id='message']/text()" is used for other messages
Co-authored-by: Sebastian Meyer <mail@bastimeyer.de>
https://www.mediastre.am/en/about-us
closes #4389
ref #4269