plugins.senategov: remove plugin #4458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just remove it completely |
Agreed. |
bastimeyer
force-pushed
the
plugins/senategov
branch
from
d8096b2 to
780b095
Compare
bastimeyer
changed the title
bastimeyer
added
plugin removal
and removed
plugin issue
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #4455
I don't know how much sense it makes fixing this plugin. It's broken since the introduction of the pluginmatcher logic (#3821), and it was still referencing
self.url_rethe whole time, which didn't exist anymore, leading to theAttributeError: 'SenateGov' object has no attribute 'url_re'error. Nobody has reported a plugin issue since then and the plugin has been very very niche to begin with. The two URLs defined in the tests are working now though. I didn't check anything else.