Skip to content

plugin.api.validate: refactor, turn into package #4514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2022
Merged

plugin.api.validate: refactor, turn into package #4514

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
57289f4
plugin.api.validate: refactor all + any
bastimeyer May 7, 2022
03e3c59
plugin.api.validate: refactor get
bastimeyer May 7, 2022
5a77225
plugin.api.validate: refactor callable
bastimeyer May 7, 2022
c5df6b2
plugin.api.validate: fix xml_element
bastimeyer May 7, 2022
d1d8057
plugin.api.validate: refactor Schema class
bastimeyer May 7, 2022
8bf91e1
plugin.api.validate: turn module into package
bastimeyer May 7, 2022
a59217b
plugin.api.validate: implement ValidationError
bastimeyer May 7, 2022
5c24fe4
plugin.api.validate: truncate error messages
bastimeyer May 7, 2022
3153e8d
plugin.api.validate: rewrite tests
bastimeyer May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
plugin.api.validate: refactor Schema class 
Inherit from the all-schema directly to avoid having an unnecessary
singledispatch type definition.
  • Loading branch information
@bastimeyer
bastimeyer committed May 7, 2022
commit d1d805755c76d60f4afe3dc5c0abcf2a3026db0a
16 changes: 5 additions & 11 deletions src/streamlink/plugin/api/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,19 +542,13 @@ def validate_unions(schema, value):
return validate_union(schema.schema, value)


class Schema:
"""Wraps a validator schema into a object."""

def __init__(self, *schemas):
self.schema = all(*schemas)
class Schema(all):
"""
Wrapper class for :class:`all` with a validate method which raises :class:`PluginError` by default on error.
"""

def validate(self, value, name="result", exception=PluginError):
try:
return validate(self.schema, value)
return validate(self, value)
except ValueError as err:
raise exception("Unable to validate {0}: {1}".format(name, err))


@validate.register(Schema)
def validate_schema(schema, value):
return schema.validate(value, exception=ValueError)