Skip to content

Fix websocket typing, fix twitcasting plugin #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

bastimeyer
Copy link
Member

Fixes #4604

See
https://github.com/websocket-client/websocket-client/blob/v1.3.2/websocket/_app.py#L345-L369

Two commits:

  1. Fix typing in WebsocketClient and export opcodes for easier access in subclasses
  2. Fix twitcasting plugin and make sure to always write bytes to the stream buffer

@bastimeyer bastimeyer added plugin issue A Plugin does not work correctly API: websocket labels Jun 18, 2022
@gravyboat gravyboat merged commit 67b9fca into streamlink:master Jun 18, 2022
@bastimeyer bastimeyer deleted the plugins/twitcasting/on-data branch June 18, 2022 04:21
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Jun 18, 2022
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: websocket plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins.twitcasting: Download ends abruptly with an error: string argument without an encoding
2 participants