Skip to content

utils.l10n: switch to locale.getlocale() #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2022
Merged

utils.l10n: switch to locale.getlocale() #4654

merged 1 commit into from
Jul 14, 2022

Conversation

bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Jul 14, 2022 •
edited
Loading

Replace locale.getdefaultlocale() with locale.getlocale(), as it's
deprecated since Python 3.11.

Also rewrite and add more tests.

No changes compared to master:

# system default
streamlink -l debug hls://file:///dev/null | grep utils.l10n
[utils.l10n][debug] Language code: en_US

# LC_ALL
env LC_ALL=de_DE.UTF-8 streamlink -l debug hls://file:///dev/null | grep utils.l10n
[utils.l10n][debug] Language code: de_DE

# LC_CTYPE
env LC_CTYPE=de_DE.UTF-8 streamlink -l debug hls://file:///dev/null | grep utils.l10n
[utils.l10n][debug] Language code: de_DE

# LANG
env LANG=de_DE.UTF-8 streamlink -l debug hls://file:///dev/null | grep utils.l10n
[utils.l10n][debug] Language code: de_DE

# LANGUAGE (unsupported)
env LANGUAGE=de_DE.UTF-8 streamlink -l debug hls://file:///dev/null | grep utils.l10n
[utils.l10n][debug] Language code: en_US

# --locale param
env LC_ALL=de_DE.UTF-8 streamlink -l debug hls://file:///dev/null --locale fr_FR | grep utils.l10n
[utils.l10n][debug] Language code: fr_FR

@bastimeyer
utils.l10n: switch to locale.getlocale()
6a90eaf 
Replace `locale.getdefaultlocale()` with `locale.getlocale()`, as it's
deprecated since Python 3.11.

Also rewrite and add more tests.
@gravyboat gravyboat merged commit 66a75f9 into streamlink:master Jul 14, 2022
@bastimeyer bastimeyer deleted the utils/l10n/getlocale branch July 14, 2022 18:04
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Jul 18, 2022
@Billy2011
[PATCH] utils.l10n: switch to locale.getlocale()(streamlink#4654)
e7236dd 
Replace `locale.getdefaultlocale()` with `locale.getlocale()`, as it's
deprecated since Python 3.11.
@bastimeyer bastimeyer mentioned this pull request Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python: 3.11 python-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastimeyer @gravyboat