Skip to content

plugins.picarto: Fix streams and VODs #4729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2022
Merged

plugins.picarto: Fix streams and VODs #4729

merged 4 commits into from
Aug 11, 2022

Conversation

skulblakka
Copy link
Contributor

For streams it looks like the page no longer includes the player JS used to read the stream server URL when loading the page without JS enabled. However it is included in the already existing call to the private API.

For VODs it seems to just complain about the type of the video ID.

Tested with some random streams.

Resolves #4727.

Before:

# Stream
streamlink https://picarto.tv/Noxcuro best
[cli][info] Found matching plugin picarto for URL https://picarto.tv/Noxcuro
[plugins.picarto][error] Could not find server netloc
error: No playable streams found on this URL: https://picarto.tv/Noxcuro

#VOD
streamlink https://picarto.tv/sate/videos/681901
[cli][info] Found matching plugin picarto for URL https://picarto.tv/sate/videos/681901
error: Unable to validate response text: ValidationError(dict):
  Unable to validate value of key 'data'
  Context(dict):
    Unable to validate value of key 'video'
    Context(AnySchema):
      ValidationError(equality):
        <{'id': 681901, 'title': 'tropical depression stream', '...> does not equal None
      ValidationError(dict):
        Unable to validate value of key 'id'
        Context(type):
          Type of 681901 should be str, but is int

After:

#Stream
streamlink https://picarto.tv/Noxcuro
[cli][info] Found matching plugin picarto for URL https://picarto.tv/Noxcuro
Available streams: 478p (worst), 720p (best)

#VOD
streamlink https://picarto.tv/sate/videos/681901
[cli][info] Found matching plugin picarto for URL https://picarto.tv/sate/videos/681901
Available streams: 1080p (worst, best)

bastimeyer
bastimeyer reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.
One minor code style change though.

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Aug 10, 2022
@bastimeyer bastimeyer merged commit 3c5abaa into streamlink:master Aug 11, 2022
@bastimeyer
Copy link
Member

Thanks

@skulblakka skulblakka deleted the fix/picarto branch August 11, 2022 08:28
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Aug 12, 2022
@Billy2011
[PATCH] plugins.picarto: fix streams and VODs (streamlink#4729)
1058e8c
light4 pushed a commit to light4/streamlink that referenced this pull request Dec 9, 2022
@skulblakka @light4
plugins.picarto: fix streams and VODs (streamlink#4729)
f6583ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastimeyer bastimeyer bastimeyer left review comments

Assignees
No one assigned
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugins.picarto: Could not find server netloc
2 participants
@skulblakka @bastimeyer