logger: add new log level "all" #4941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravyboat
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Typically I would expect this to be at the trace level but as you noted it's even more verbose than what might be seen there so I'm fine with calling it all even though it's non-standard (who really cares as long as we get the info). I'm going to mark this as approved @bastimeyer and you can merge it whenever.
This was referenced Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging extremely verbose data like HLS playlist contents for example doesn't really fit on the
tracelog level. Adding an ultimate verbosity log level makes more sense here, so we can add log calls to the HLS parser and similar things.Is the name "all" fine? I've just renamed it from "paranoid" before submitting this PR, because I wasn't really happy with that name. "all" is the opposite of "none", which is at the other end of the log level list, and it's easier to remember, too.
Since there are two custom log levels now, I had to refactor a bit of code in order to prevent duplicate stuff and duplicate tests.