exceptions: update docs, fix NoPluginError and remove url arg from NoStreamsError #5088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make `NoPluginError` inherit from `StreamlinkError` instead of `PluginError` - Update and fix docstrings of all Streamlink exception classes - Update list of exceptions in API docs - Fix exports
|
Btw, no idea why streamlink/src/streamlink/plugin/plugin.py Lines 383 to 384 in ae75834 And the empty streams error message is coming from the main CLI module: streamlink/src/streamlink_cli/main.py Lines 554 to 555 in ae75834 |
bastimeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoPluginErrorinherit fromStreamlinkErrorinstead ofPluginErrorNoPluginErroris only raised here and caught in the main CLI module where URLs get resolved. It shouldn't inherit fromPluginError, because it's something entirely different.