Skip to content

docs: remove Open Collective #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

bastimeyer
Copy link
Member

  • Rewrite the documentation's donate page
    • Remove donation infos from individual team members
    • Add all team members
    • Fix GitHub username regex in Sphinx extension
  • Rewrite the project README
    • Use HTML for centered text, add logo, update badges
    • Rephrase text sections
    • Remove Open Collective and update support section
  • Replace all links to Open Collective with a link to the latest docs

Opening this as a draft, since we haven't closed the Open Collective account yet, as we're still waiting for a response from one of the team members in the internal discussion. Once done and once the account has been closed, I will open a meta thread on the issue tracker, so people who have set up a recurring donation can be informed in addition to these changes.

As you can see, I've also decided to clean up and polish the README. You can see the rendered results on my branch. The README also gets used in the sdist and wheel metadata, which is then read by PyPI on the streamlink package page. There shouldn't be any issues though. I've validated it with twine check dist/... and checked other packages which use HTML in their package description, e.g. charset-normalizer.

The donation links of individual people was removed, because keeping this updated in the docs is a bit tedious and annoying. The donation page is referring to each person's github account, so donation information can be added there.

@bastimeyer
Copy link
Member Author

- Rewrite the documentation's donate page
  - Remove donation infos from individual team members
  - Add all team members
  - Fix GitHub username regex in Sphinx extension
- Rewrite the project README
  - Use HTML for centered text, add logo, update badges
  - Rephrase text sections
  - Remove Open Collective and update support section
- Replace all links to Open Collective with a link to the latest docs
@bastimeyer bastimeyer force-pushed the docs/remove-opencollective branch from 806d0bb to 9cb8cd6 Compare February 7, 2023 20:49
@bastimeyer
Copy link
Member Author

Opening this as a draft, since we haven't closed the Open Collective account yet, as we're still waiting for a response from one of the team members in the internal discussion.

Still no update... Let's get these changes merged though. I don't think it's useful having OC still included in the readme. Please review.

@bastimeyer bastimeyer marked this pull request as ready for review February 11, 2023 11:07
@gravyboat gravyboat merged commit a0a5af6 into streamlink:master Feb 11, 2023
@bastimeyer bastimeyer deleted the docs/remove-opencollective branch February 11, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants