docs: rewrite install page #5178
Merged
+296
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add header grid-cards for quickly choosing the OS or PyPI package - Rename "AppImages" section to "Linux AppImages" - Greatly reduce noise in the "Windows binaries" and "Linux AppImages" sections by replacing texts and lists with grid-cards and tables, and remove "stable/nightly builds" sub-sections respectively - Add SVG logos for Python and FFmpeg, obtained from original sources, with slight modifications and optimizations applied - Move up "Dependencies" section by one level - Rewrite some texts for better clarity and fix some grammar errors - Upgrade font-awesome from 5 to 6
|
Btw, there are a few unintentional line wraps in the cards on mobile (narrow document width), but nothing too bad. |
gravyboat
reviewed
Feb 18, 2023
Comment on lines
+466
to
+469
| - :bdg-link-secondary-line:`Windows 7 <https://github.com/streamlink/windows-builds/releases>` | ||
| - :bdg-link-secondary-line:`Windows 7 <https://github.com/streamlink/windows-builds/releases>` | ||
| - :bdg-link-secondary-line:`Windows 7 <https://github.com/streamlink/windows-builds/releases>` | ||
| - :bdg-link-secondary-line:`Windows 7 <https://github.com/streamlink/windows-builds/releases>` |
There was a problem hiding this comment.
Not the discussion to have here but I think we should stop building for Windows 7, it's EoL software and there's no reason to support it.
There was a problem hiding this comment.
I don't care. It's only a matter of adding different checksums for me. People shouldn't be using Windows at all.
|
Changes look great. I'm not concerned about the mobile wrapping issue since this isn't a mobile first project. |
|
Why is there no CI run for the merge on master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4987
Now that the
sphinx-designextension was added, let's make the install page a bit more easier to navigate...Please give this a thorough check and proof-read.