stream.dash: various SegmentList/SegmentTemplate fixes #5247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Turn `SegmentList` into an only-child in `Period`, `AdaptationSet` and `Representation` - Set `parent` type in `SegmentList` - Turn `SegmentList.segments` from a property into a regular method, similar to `SegmentTemplate.segments()`
Inherit attributes from ancestor `SegmentList` nodes, if set, similar to `SegmentTemplate`. Also fix `presentationTimeOffset` not being inherited in `SegmentTemplate`. TODO: use common `MultipleSegmentBaseType` class for these attributes
The number of `SegmentURL` nodes in `SegmentList` can be zero, e.g. when the `SegmentList` gets overridden in a descendant node
- Fix `SegmentTimeline` in `SegmentTemplate` and find ancestor timelines - Add `SegmentTimeline` to `SegmentList` (currently unused)
bastimeyer
force-pushed
the
stream/dash/fix-segment-list
branch
from
a52c80b to
ab7de68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of
SegmentList(andSegmentTemplate) fixes. Motivation in each commit message.Changes are required for implementing
SegmentTimelineprocessing inSegmentListlater on (YouTube live streams with timeshift).