plugins.youtube: check playabilityStatus.reason #5351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, YouTube always sets the `playabilityStatus.status` value to `"OK"` on broken live streams, even if `playabilityStatus.reason` is set to a specific error message. Valid live streams and videos have set the `playabilityStatus.reason` value to `None`, so just check whether the value is truthy.
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, YouTube always sets the
playabilityStatus.statusvalue to"OK"on broken live streams, even ifplayabilityStatus.reasonis set to a specific error message.Valid live streams and videos have set the
playabilityStatus.reasonvalue toNone, so just check whether the value is truthy.Resolves #5350
I'd like to see a confirmation from someone else first that the assumption that
playabilityStatus.reasonisNoneon valid streams is actually correct. If it's not, then we unintentionally return no streams with these changes, which would be bad.