Add Chrome Devtools Protocol modules #5381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
bastimeyer
force-pushed
the
generate-cdp
branch
2 times, most recently
from
67c2f1d to
b86445e
Compare
|
Rebased to current head of master, because this PR is the base branch for other PRs until it got merged into master. |
- Add inflection to dev-requirements - Add argparser - Add package output path - Add version selection - Add domain selection - Fetch protocol JSON files from gh:ChromeDevTools/devtools-protocol - Fetch latest version from NPMJS if unset (latest tag by date) - Include util.py - Clean up headers and imports of generated modules - Re-order clean+write logic in output path - Remove docs/sphinx related stuff - Remove deprecation notes - Remove custom protocol patches/hacks - Fix generated code style - Fix domain self-references - Fix command param order
domain selection: fetch runtime input dom
|
Rebased to master, no other changes. Going to merge now, so I can rebase the dependent PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1/4 of #5380
CDP documentation here:
https://chromedevtools.github.io/devtools-protocol/
Generator script borrowed from:
https://github.com/HyperionGray/python-chrome-devtools-protocol
This
fetch,runtime,input, anddom, as well as all their dependent domains and the mandatorytargetandinspectordomains.Anything else is not worth adding in my opinion. As you can see, this already adds 17k lines of code...
Opening as a draft until I have the remaining stuff ready.