cli.argparser: fix config file args parser #5484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
bastimeyer
force-pushed
the
cli/argparser/fix-config-file-args-parser
branch
3 times, most recently
from
40138ca to
ad70d6c
Compare
- Fix options regex
- parse all alphanumerical options with dashes
- be more strict around the option-value operator
and properly ignore invalid option formats, just like comments
- Fix parsing of shorthand options
- Add tests
bastimeyer
force-pushed
the
cli/argparser/fix-config-file-args-parser
branch
from
ad70d6c to
a2f7172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5481
Option names containing numbers now get properly parsed.
This also fixes the parsing of shorthand options in config files, so something like this works now
This also fixes options with empty values
And invalid option formats now get properly ignored, just like comments, so
won't result in
--non=_matching_optionbeing returned anymore