stream.segmented: fix and add more typing #5507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
Will fix the py38 errors tomorrow... |
- Turn `SegmentedStream{Writer,Worker,Reader}` into generic classes
with `TSegment` and `TResult` types
- Fix typing information of the writer's queue
- Add missing typing information
- Update segmented stream implementations/subclasses accordingly
bastimeyer
force-pushed
the
stream/generic-segmented
branch
from
5652409 to
bb83f4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SegmentedStream{Writer,Worker,Reader}into generic classes with segment and segment-result types#5498
Next step will be fixing the whole
Segmentmess by adding a commonBaseSegment. This will require more changes due to how the current segments are implemented and structured.