Skip to content

plugins.pluto: fix HLS playlist parameters #5551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

plugins.pluto: fix HLS playlist parameters #5551

merged 1 commit into from
Sep 13, 2023

Conversation

bastimeyer
Copy link
Member

  • Fix query string parsing
  • Extend segment filtering regex

Resolves #5546

@Metroid2023 could you please check and verify a couple of different channels? Thanks.
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback

before (invalid playlist URL -> infinite filler segments)

$ streamlink 'https://pluto.tv/en/live-tv/pluto-tv-1-de' best --stream-url
https://cfd-v4-service-channel-stitcher-use1-1.prd.pluto.tv/stitch/hls/channel/640f4f4083f589000828a544/3063648/playlist.m3u8?terminate=false&sid=%5B'de168fa0-51c7-11ee-baa2-b24a1066bf11'%5D&deviceDNT=0&deviceLat=%5B'50.8035'%5D&deviceLon=%5B'6.4921'%5D&deviceModel=%5B'web'%5D&deviceVersion=%5B'94.0.0'%5D&appName=%5B'web'%5D&deviceId=%5B'23962ec1-3b63-4420-acb2-eb9a035628fa'%5D&appVersion=%5B'7.7.0-18f7ab32608969ea5bcbce8d0e23b9d0e1b24717'%5D&deviceType=%5B'web'%5D&deviceMake=%5B'firefox'%5D

after (stream working correctly)

$ streamlink 'https://pluto.tv/en/live-tv/pluto-tv-1-de' best --stream-url
https://cfd-v4-service-channel-stitcher-use1-1.prd.pluto.tv/stitch/hls/channel/640f4f4083f589000828a544/3063648/playlist.m3u8?terminate=false&sid=cc24afe8-51c7-11ee-a406-6e1a08ee6a29&deviceDNT=0&deviceLat=50.8035&deviceLon=6.4921&deviceModel=web&deviceVersion=94.0.0&appName=web&deviceId=2cd87f0d-f7c4-4333-94a7-513bb0f2c122&appVersion=7.7.0-18f7ab32608969ea5bcbce8d0e23b9d0e1b24717&deviceType=web&deviceMake=firefox

@bastimeyer
plugins.pluto: fix HLS playlist parameters
c387ec2 
- Fix query string parsing
- Extend segment filtering regex
@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Sep 12, 2023
gravyboat
gravyboat approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@gravyboat gravyboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending confirmation of success from issue reporter.

@Metroid2023
Copy link

Thank you very much! It fixed!

@bastimeyer bastimeyer merged commit 230f102 into streamlink:master Sep 13, 2023
@bastimeyer bastimeyer deleted the plugins/pluto/fix-hls-params branch September 13, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravyboat gravyboat gravyboat approved these changes

Assignees
No one assigned
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugins.Pluto: Freezes at commercials and plays no audio on TV Shows
3 participants
@bastimeyer @Metroid2023 @gravyboat