Skip to content

plugins.ntv: remove plugin #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2023
Merged

plugins.ntv: remove plugin #5604

merged 1 commit into from
Oct 11, 2023

Conversation

bastimeyer
Copy link
Member

Resolves #5602

Static HLS URLs:

$ curl -sSL 'https://www.ntv.ru/api/new/widgets/air/schedule/index.jsp?channel=ntv' \
  | jq -r '.data.src'
https://cdn.ntv.ru/ntv0_hd/index.m3u8?filter.tracks=v3v4v5a1l1t1
$ curl -sSL 'https://www.ntv.ru/api/new/widgets/air/source/index.jsp' \
  | jq -r '.data.channels[] | .src'
https://cdn.ntv.ru/live7/index.m3u8
https://cdn.ntv.ru/th_style/index.m3u8
https://cdn.ntv.ru/th_serial/index.m3u8
https://cdn.ntv.ru/th_pravo/index.m3u8
https://cdn.ntv.ru/ntv0_hd/rewind-7150.m3u8?filter.tracks=v2v1v3v4v5a1l1t1
https://cdn.ntv.ru/unknown_russia/index.m3u8

@bastimeyer
Copy link
Member Author

It doesn't let me merge this from the PR UI here...

This branch cannot be rebased due to too many changes

???

$ git show --stat --format=reference | cat
7929dce2 (plugins.ntv: remove plugin, 2023-10-11)

 src/streamlink/plugins/ntv.py | 31 -------------------------------
 tests/plugins/test_ntv.py     | 16 ----------------
 2 files changed, 47 deletions(-)

$ git log --format=reference HEAD~2..HEAD | cat
7929dce2 (plugins.ntv: remove plugin, 2023-10-11)
0490c4ef (plugins.vlive: remove plugin, 2023-10-09)

$ curl -sSL 'https://api.github.com/repos/streamlink/streamlink/commits?per_page=1' | jq -r '.[0].sha'
0490c4eff16d3afad1566647a1eb3b91a1f4f59f

$ curl -sSL 'https://api.github.com/repos/streamlink/streamlink/commits/0490c4eff16d3afad1566647a1eb3b91a1f4f59f/branches-where-head' | jq -r '.[] | .name'
master

@mkbloke
Copy link
Member

mkbloke commented Oct 11, 2023

Yes. I was going to merge it about 5 minutes ago, but I saw that and thought I'd leave it well alone, not understanding why it's saying that...

@bastimeyer
Copy link
Member Author

It's a bug according to GH community discussions. I could fast-forward this commit onto master (since the branch-protection rules require passing tests, which this commit does have), but I will instead submit a bug report to them first...

@bastimeyer
Copy link
Member Author

With a new commit being pushed to master, it allows me to rebase-merge again...

@bastimeyer bastimeyer merged commit e197337 into streamlink:master Oct 11, 2023
@bastimeyer bastimeyer deleted the plugins/ntv/remove branch October 11, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravyboat gravyboat gravyboat approved these changes

Assignees
No one assigned
Labels
plugin removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugins.ntv: it have dead today
3 participants
@bastimeyer @mkbloke @gravyboat