Skip to content

plugins.nasaplus: new plugin #5664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2023
Merged

plugins.nasaplus: new plugin #5664

merged 1 commit into from
Nov 16, 2023

Conversation

bastimeyer
Copy link
Member

Opening this as a draft since there's currently no live stream running, only one scheduled stream in 3 days... No idea if live streams will have a different site layout.

$ ./script/test-plugin-urls.py nasaplus
:: Finding streams for URL: https://plus.nasa.gov/scheduled-video/iss-expedition-70-in-flight-educational-event-with-the-creative-learning-academy-in-pensacola-florida-and-nasa-flight-engineer-jasmin-moghbeli/
:: Found streams: 720p_alt2, 720p_alt, 720p, worst, best
:: Finding streams for URL: https://plus.nasa.gov/video/moon-101-introduction-to-the-moon/
:: Found streams: 79k, 234p, 270p, 360p_alt, 360p, 540p, 720p_alt, 720p, 1080p, worst, best

$ streamlink -j 'https://plus.nasa.gov/scheduled-video/iss-expedition-70-in-flight-educational-event-with-the-creative-learning-academy-in-pensacola-florida-and-nasa-flight-engineer-jasmin-moghbeli/' best | jq .metadata
{
  "id": null,
  "author": null,
  "category": null,
  "title": "ISS Expedition 70 In-Flight Educational Event"
}

@bastimeyer bastimeyer force-pushed the plugins/nasaplus/init branch from b1da8ad to 6f34e76 Compare November 16, 2023 20:19
@bastimeyer bastimeyer marked this pull request as ready for review November 16, 2023 20:19
@bastimeyer
Copy link
Member Author

Live streams are working fine with the same implementation:

$ streamlink https://plus.nasa.gov/scheduled-video/nasa-science-live-the-science-behind-your-favorite-planet-being-in-retrograde/ best
[cli][info] Found matching plugin nasaplus for URL https://plus.nasa.gov/scheduled-video/nasa-science-live-the-science-behind-your-favorite-planet-being-in-retrograde/
[cli][info] Available streams: 720p_alt2 (worst), 720p_alt, 720p (best)
[cli][info] Opening stream: 720p (hls)
[cli][info] Starting player: mpv
[cli][info] Player closed
[cli][info] Stream ended
[cli][info] Closing currently open stream...

$ streamlink -j https://plus.nasa.gov/scheduled-video/nasa-science-live-the-science-behind-your-favorite-planet-being-in-retrograde/ best | jq .metadata
{
  "id": null,
  "author": null,
  "category": null,
  "title": "NASA Science Live: The Science Behind Your Favorite Planet Being in Retrograde"
}

@bastimeyer bastimeyer merged commit b680d38 into streamlink:master Nov 16, 2023
@bastimeyer bastimeyer deleted the plugins/nasaplus/init branch November 16, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bastimeyer