cli: improve quoted player path warning #5757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkbloke
reviewed
Jan 3, 2024
src/streamlink_cli/output/player.py
Outdated
| @@ -235,8 +235,11 @@ def _open(self): | |||
| warnings.warn( | |||
| "\n".join([ | |||
| "The --player argument has been changed and now only takes player path values:", | |||
| " Player paths with spaces don't have to be wrapped in quotation marks anymore.", | |||
| " Custom player arguments need to be set via --player-args.", | |||
| " Player paths with spaces must not be wrapped in additional quotation marks", | |||
There was a problem hiding this comment.
It might sound pedantic (I'm just thinking about interpretation), but does this message mean paths without spaces can be wrapped in quotation marks?
Would it be better if it just read:
Player paths must not be wrapped in quotation marks?
bastimeyer
force-pushed
the
cli/output/update-quoted-player-path-warning
branch
from
c137beb to
5dced40
Compare
mkbloke
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5756