plugins.twitch: disable headless mode #5758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5600
This ignores the
--webbrowser-headlessconfig in the Twitch plugin and always forcesheadlessto beFalse, because Twitch is able to detect Chromium's headless mode when forcing the acquirement of the client-integrity token. You can check this easily by setting an invalid OAuth token for example (--twitch-api-header="Authorization=OAuth invalid") or by modifying the plugin.The CI tokens are currently not a requirement, but this can change at any time, and if they do and Streamlink has headless mode enabled by default (which is the case), then users are forced to update their configs or CLI arguments until we publish a new release, which is unnecessary. So let's set
headlesstoFalsein the Twitch plugin now.