Skip to content

plugins.showroom: fix geo-block check #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2024
Merged

plugins.showroom: fix geo-block check #5911

merged 1 commit into from
Mar 29, 2024

Conversation

bastimeyer
Copy link
Member

Fixes #5909

The HLS streams now have the correct Content-Type header according to rfc8216, namely application/vnd.apple.mpegurl.

$ curl -I https://hls-css.live.showroom-live.com/live/17d0561da8f8c7d0e2f70005699c3088916f1b91b60a7dc8bde88ebb69da054b_default.m3u8 | grep content-type
content-type: application/vnd.apple.mpegurl

Streams are working fine with this fix when accessing from a Japanese IP address:

$ streamlink https://www.showroom-live.com/r/SAKURAGI_RICO best
[cli][info] Found matching plugin showroom for URL https://www.showroom-live.com/r/SAKURAGI_RICO
[cli][info] Available streams: 144p (worst), 360p, 1080p (best)
[cli][info] Opening stream: 1080p (hls)
[cli][info] Starting player: /usr/bin/mpv
[cli][info] Player closed
[cli][info] Stream ended
[cli][info] Closing currently open stream...

@bastimeyer bastimeyer added plugin issue A Plugin does not work correctly restriction: geo blocked labels Mar 29, 2024
@bastimeyer bastimeyer merged commit 3d8860e into streamlink:master Mar 29, 2024
@bastimeyer bastimeyer deleted the plugins/showroom/fix-geoblock-check branch March 29, 2024 17:23
@CplSgt82
Copy link

CplSgt82 commented Mar 29, 2024 •
edited
Loading

Thank you everything is working fine now, I just want to add that a Japanese IP address is not necessary for it to work. (Tested with a VPN)
The plugin will work as long as the region of the IP address is not geo-blocked by Showroom.
For eg. Singapore, Hong Kong, USA, Canada etc
Regions that are geo-blocked: Most of Europe, South Africa

@bastimeyer bastimeyer mentioned this pull request Apr 1, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin issue A Plugin does not work correctly restriction: geo blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugins.showroom: streamlink unable to download any live streams from showroom.com
2 participants
@bastimeyer @CplSgt82