cli.utils.formatter: respect max file name length #5921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
changed the title
gravyboat
approved these changes
Apr 3, 2024
bastimeyer
force-pushed
the
cli/utils/formatter/truncate-filename
branch
from
1020dfd to
5059ed2
Compare
bastimeyer
commented
Apr 3, 2024
Comment on lines
+45
to
+51
| # no file name extension (no dot separator in path or file name extension too long): | ||
| # truncate the whole thing | ||
| if not keep_extension or len(parts) == 1 or len(parts[1]) > 10: | ||
| encoded = path.encode("utf-8") | ||
| truncated = encoded[:length] | ||
| decoded = truncated.decode("utf-8", errors="ignore") | ||
| return decoded |
There was a problem hiding this comment.
Btw, the or len(parts[1]) > 10 check is added here so that only file name extensions with fewer than 11 characters will be kept. We must avoid unnecessary file name truncation in cases where --output="{title}" (no user-set file name extension) and when the title metadata includes a dot somewhere in its value. Without the check, the whole text after the last dot would be treated as a file name extension and always be kept, unnecessarily reducing the available space before of the last dot.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5919
To make sense of this in just a few seconds, just have a look at the two tests added in the last commit...