Skip to content

plugin.api.validate: check parse_qsd() input type #5932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bastimeyer
Copy link
Member

Fixes #5931

Since Python 3.11.9 / 3.12.3 / 3.13.0a6, urllib.parse.parse_qsl() now raises a TypeError if the input is not a str, is truthy and can't be passed to memoryview(), like integers for example, hence the test failure which previously just checked an invalid input to that validation schema.

@bastimeyer bastimeyer merged commit 0466622 into streamlink:master Apr 9, 2024
@bastimeyer bastimeyer deleted the plugin/api/validate/parse-qsd-check-type branch April 9, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: py311: FAILED tests/test_api_validate.py::TestParseQsdValidator::test_failure
1 participant