Skip to content

tests: fix test_onbuild when executed from build directory #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amurzeau
Copy link
Contributor

@amurzeau amurzeau commented Apr 9, 2024

When executing tests from the build directory (generated by bdist), the location of the Streamlink source is directly at the root directory and not in a src subdirectory.

This is what Debian does when building python packages to ensure newly built files are tested instead of source files.

Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amurzeau amurzeau force-pushed the tests_build_backend_fix_from_build_dir branch from fe7c66a to 7ed649d Compare April 9, 2024 23:26
When executing tests from the build directory (generated by bdist),
the location of the Streamlink source is directly at the root directory
and not in a `src` subdirectory.

This is what Debian does when building python packages to ensure newly
built files are tested instead of source files.
@amurzeau amurzeau force-pushed the tests_build_backend_fix_from_build_dir branch from 7ed649d to b3a18ef Compare April 9, 2024 23:29
@bastimeyer bastimeyer merged commit a906592 into streamlink:master Apr 9, 2024
amurzeau added a commit to amurzeau/streamlink-debian that referenced this pull request Apr 15, 2024
This requires a fix in test_onbuild, see here:
streamlink/streamlink#5933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants