Skip to content

Remove deprecated plugin.api/plugins import paths #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bastimeyer
Copy link
Member

One PR for both removals... I will have to rebase with the updated PR number after submitting this one.

  1. The import paths for streamlink.plugin.api.HTTPSession, streamlink.plugin.api.http_session.{HTTPSession,TLSNoDHAdapter,TLSSecLevel1Adapter} were deprecated in session: re-organize session and http_session modules #5807 (6.6.0)
  2. The import paths for streamlink.plugins.{NoPluginError,NoStreamsError,PluginError,Plugin} were deprecated for more than 10 years, with official deprecation warnings being added in plugins: officially deprecate re-exports #6005 (6.8.0)

Even though some of these deprecation phases were rather short, it's time to remove this in the upcoming 7.0.0 release. It's a trivial change.

- remove deprecated `HTTPSession` from `streamlink.plugin.api`
- remove deprecated `streamlink.plugin.api.http_session` module
@bastimeyer bastimeyer force-pushed the plugin/remove-deprecated-import-paths branch from 6f17b95 to 21e2b77 Compare November 1, 2024 17:42
@bastimeyer bastimeyer mentioned this pull request Nov 1, 2024
23 tasks
@bastimeyer bastimeyer force-pushed the plugin/remove-deprecated-import-paths branch from 21e2b77 to 62d3402 Compare November 1, 2024 17:46
Remove deprecated re-exports from `streamlink.plugins` and update tests:
- `NoPluginError`
- `NoStreamsError`
- `PluginError`
- `Plugin`
@bastimeyer bastimeyer force-pushed the plugin/remove-deprecated-import-paths branch from 62d3402 to 3c2d88a Compare November 1, 2024 17:47
Copy link
Member

@gravyboat gravyboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Documentation is very clear.

@bastimeyer bastimeyer merged commit 7b61a59 into streamlink:master Nov 1, 2024
23 checks passed
@bastimeyer bastimeyer deleted the plugin/remove-deprecated-import-paths branch November 1, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants