Skip to content

options: make Arguments inherit from dict #6298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

options: make Arguments inherit from dict #6298

merged 1 commit into from
Nov 18, 2024

Conversation

bastimeyer
Copy link
Member

Instead of using an internal arguments dict attribute, make Arguments inherit from dict[str, Argument] directly, so it's shown as a dict type in the rendered docs.

Follow-up of #6297

@bastimeyer
options: make Arguments inherit from dict
0e8fa4d 
Instead of using an internal `arguments` dict attribute,
make `Arguments` inherit from `dict[str, Argument]` directly,
so it's shown as a dict type in the rendered docs.
@bastimeyer
Copy link
Member Author

Before:

arguments: ClassVar[Arguments] = <streamlink.options.Arguments object>

After:

arguments: ClassVar[Arguments] = {}

@bastimeyer bastimeyer merged commit 12aa5fd into streamlink:master Nov 18, 2024
23 checks passed
@bastimeyer bastimeyer deleted the options/arguments-dict branch November 18, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API: plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bastimeyer