plugins.pluzz: fix video ID schemas #6428
Merged
+50
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
added
plugin issue
Seem to work correctly for all the links you provided without authentification.
Rugby (crunch) ;)
I can confirm. Nice job. |
Thanks, but I was asking for links that are not included in that list. Going to merge anyway... |
Sorry, I don't know any others. And I didn't even know all of these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6427
This fixes the broken video ID validation schemas.
@novazur972 please check and see if any other streams on the site are not working correctly
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback
While working on the initial changes earlier this evening, I didn't check whether authentication was actually required, because the video ID schemas were still broken. They were showing a football match at the time on the france-2 channel, so I don't know if authentication is required only for certain kinds of content.
I have a second commit that's not part of this PR branch that adds support for authentication (just noticed that it's not working 100% correctly before opening this PR, irrelevant though). If it turns out that authentication is indeed required - and I still don't know - then this will be fixed in another PR.
As you can see, no authentication required, at least right now (using a French proxy - socks5 over SSH):