-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
plugins.pandalive: fix user_id, update matcher #6433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins.pandalive: fix user_id, update matcher #6433
Conversation
03dc6a0
to
52d993a
Compare
no problem, plugin is working now. thanks. |
The reason why I'm always asking for feedback is that those users who've reported the issue should go ahead and check the updated plugin with input URLs that I didn't or couldn't check myself, because in 99% of the cases I don't use any of these sites and I'm not familiar with them. What about offline channels, or anything else that could prevent access, like locked streams, etc.? Just saying "it works" doesn't mean anything if you don't post a debug log. |
Sometimes it reports a 403 error, but sometimes it's normal
|
This is a Frankenstein Streamlink install you're using. You are not supposed to overwrite any files in an old version, especially plugin files. The proper way of installing from a PR is documented in the PR feedback docs linked above, as well as in Streamlink's full docs. Any log outputs of those modified versions are meaningless and thus not helpful. The 403 HTTP response in your logs comes from trying to access the resolved HLS playlist URL. I don't see any issues of that kind when checking streams in an infinite loop while using the latest unmodified version. All resolved HLS playlist URLs return a 200 status.
I'm just going to merge this, even though I didn't receive the feedback that I was looking for. Thanks anyways... |
Fixes #6432
@KOONWHITE @lloyd18
Please check and see if some streams are not working correctly. My local tests appeared fine, but I only checked one stream I picked randomly while using my local German IP address.
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback
When requesting the input URL, their servers return an HTTP 500 status. That's also the case in your web browser, btw. Since extracting the user/channel ID from the HTML page which the previous plugin implementation did was already a bit questionable, the simple fix was to request it from their API instead.