cli: allow --retry-streams to be set to 0 #6455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
cli/retry-streams-zero
branch
from
a03bf20 to
c9efd09
Compare
simvesel
reviewed
Mar 2, 2025
src/streamlink_cli/argparser.py
Outdated
| """, | ||
| ) | ||
| stream.add_argument( | ||
| "--retry-max", | ||
| metavar="COUNT", | ||
| type=num(int, ge=0), | ||
| help=""" | ||
| When using --retry-streams, stop retrying the fetch after `COUNT` retry | ||
| attempt(s). Fetch will retry infinitely if `COUNT` is zero or unset. | ||
| Stop fetching the list of available streams after `COUNT` attempt(s). |
There was a problem hiding this comment.
Thank you very much for implementing the request.
In my opinion, for easier to understand documentation better using retry:
COUNTretry attempt(s)
- Don't retry fetching streams if `--retry-streams` and `--retry-max` are both set to zero. This was previously only possible if both were unset. - Update CLI argument help texts accordingly - Fix `FatalPluginError` not being handled properly on first try - Add tests for `fetch_streams_with_retry()`
bastimeyer
force-pushed
the
cli/retry-streams-zero
branch
from
c9efd09 to
a5f2076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--retry-streamsand--retry-maxare both set to zero. This was previously only possible if both were unset.FatalPluginErrornot being handled properly on first tryfetch_streams_with_retry()Resolves #6454
Any comprehension issues with the updated help texts? They should be fine now IMO.
https://streamlink--6455.org.readthedocs.build/cli.html#cmdoption-retry-streams