Skip to content

stream.hls: fix media name cmp in audio-select #6479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bastimeyer
Copy link
Member

Fixes #6478
Introduced by #6469

The Media.name attribute should also be considered when selecting additional audio streams, just like before the changes of #6469. Since #6469 turned the values of --hls-audio-select to lowercase for case-insensitive language lookups, we need to compare the lowercase name attribute and thus make it case-insensitive as well.

@bastimeyer bastimeyer force-pushed the stream/hls/fix-audio-select-media-name-attr branch 2 times, most recently from d592700 to ed3e63b Compare March 27, 2025 11:12
@bastimeyer bastimeyer force-pushed the stream/hls/fix-audio-select-media-name-attr branch from ed3e63b to 3f4dced Compare March 27, 2025 11:15
@bastimeyer bastimeyer merged commit 49e5da1 into streamlink:master Mar 27, 2025
27 of 28 checks passed
@bastimeyer bastimeyer deleted the stream/hls/fix-audio-select-media-name-attr branch March 27, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream.hls: --hls-audio-select doesn't consider names of audio streams anymore?
1 participant