stream.hls: fix media name cmp in audio-select #6479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
stream/hls/fix-audio-select-media-name-attr
branch
2 times, most recently
from
d592700 to
ed3e63b
Compare
and update tests
bastimeyer
force-pushed
the
stream/hls/fix-audio-select-media-name-attr
branch
from
ed3e63b to
3f4dced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6478
Introduced by #6469
The
Media.nameattribute should also be considered when selecting additional audio streams, just like before the changes of #6469. Since #6469 turned the values of--hls-audio-selectto lowercase for case-insensitive language lookups, we need to compare the lowercasenameattribute and thus make it case-insensitive as well.