Skip to content

webbrowser.cdp.devtools: update to v0.0.1438564 #6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bastimeyer
Copy link
Member

This updates Streamlink's Chrome DevTools Protocol interfaces to v0.0.1438564.
The last update was v0.0.1359167 in #6211 (2024-09-30)

Streamlink's CDP interfaces currently emit warnings due to new additions in the recent CDP versions implemented in Chromium that are not recognized. For example:

$ streamlink twitch.tv/CHANNEL --twitch-force-client-integrity --twitch-purge-client-integrity 
[cli][info] Found matching plugin twitch for URL twitch.tv/CHANNEL
[plugins.twitch][info] Removing cached client-integrity token...
[plugins.twitch][info] Acquiring new client-integrity token...
[webbrowser.webbrowser][info] Launching web browser: /usr/bin/chromium (headless=True)
[webbrowser.cdp.connection][warning] Unknown CDP event message received: Page.frameStartedNavigating
[webbrowser.cdp.connection][warning] Unknown CDP event message received: Page.frameStartedNavigating
[cli][info] Available streams: audio_only, 160p (worst), 360p, 480p, 720p60, 1080p60 (best)

After the update to the latest version

$ streamlink twitch.tv/CHANNEL --twitch-force-client-integrity --twitch-purge-client-integrity 
[cli][info] Found matching plugin twitch for URL twitch.tv/CHANNEL
[plugins.twitch][info] Removing cached client-integrity token...
[plugins.twitch][info] Acquiring new client-integrity token...
[webbrowser.webbrowser][info] Launching web browser: /usr/bin/chromium (headless=True)
[cli][info] Available streams: audio_only, 160p (worst), 360p, 480p, 720p60, 1080p60 (best)

Updating the CDP version also required adjusting some tests due to newly added parameters to the Page.enable() method.


Same domain selection: fetch runtime input dom

$ ./script/generate-cdp.py fetch runtime input dom
Output: /home/basti/repos/streamlink/src/streamlink/webbrowser/cdp/devtools
Fetching latest tag from NPMJS
Latest tag: v0.0.1438564
Fetching https://github.com/ChromeDevTools/devtools-protocol/raw/v0.0.1438564/json/browser_protocol.json
Fetching https://github.com/ChromeDevTools/devtools-protocol/raw/v0.0.1438564/json/js_protocol.json
Parsing domains...
Writing output...
Generating module: Browser -> browser.py
Generating module: Debugger -> debugger.py
Generating module: DOM -> dom.py
Generating module: Emulation -> emulation.py
Generating module: Fetch -> fetch.py
Generating module: Input -> input_.py
Generating module: Inspector -> inspector.py
Generating module: IO -> io.py
Generating module: Network -> network.py
Generating module: Page -> page.py
Generating module: Runtime -> runtime.py
Generating module: Security -> security.py
Generating module: Target -> target.py

Domain selection: fetch runtime input dom
@bastimeyer
Copy link
Member Author

RTD is failing, but it's unrelated (git fetch issue)...

@bastimeyer bastimeyer merged commit 95f9acc into streamlink:master Mar 27, 2025
22 of 23 checks passed
@bastimeyer bastimeyer deleted the webbrowser/cdp/devtools/v0.0.1438564 branch March 27, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant