plugins.kick: solve JS challenge #6500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kick once again returns 403 HTTP responses on their API with the current plugin version on master.
Solving the JS challenge and using the resulting cookies should work. This is now the third or fourth attempt of me implementing this, because the previous PRs all turned out to be unnecessary. I however could verify a few minutes ago before my IP address once again got whitelisted that accessing the API with the JS challenge cookies works. Whether it's unnecessary again because of some missing HTTP headers, like twice previously, I don't know. But since I got whitelisted again, I can't verify this, because even master works again from my end.
I'd therefore very much appreciate PR feedback from anyone. Please give this a quick try.
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback
My patience with this plugin is about to run out though. Weird coincidence that the plugin breaks as soon as a fix has been published, several times now. Also, if I don't get any feedback on this, I'm tempted to simply remove the plugin and be done with it.