stream: set specific names for each thread #6556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `NamedThread` class that automatically sets its name from its class name, with an optional suffix, and with a unique counter - Make `SegmentedStreamWriter` and `SegmentedStreamWorker` subclass from `NamedThread` and pass through the optional `name` suffix - Make `SegmentedStreamReader` and its subclasses (HLS and DASH) set the optional name suffix for its writer and worker threads, and fix signature of the Twitch plugin's subclass - Add `name` argument to `HLSStream`, so it can be passed to its reader - Make `MuxedHLSStream` set the "audio" suffix for all audio substreams - Add and update existing tests accordingly
bastimeyer
force-pushed
the
stream/thread-names
branch
from
6c2fd56 to
5b8dbee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NamedThreadclass that automatically sets its name from its class name, with an optional suffix, and with a unique counterSegmentedStreamWriterandSegmentedStreamWorkersubclass fromNamedThreadand pass through the optionalnamesuffixSegmentedStreamReaderand its subclasses (HLS and DASH) set the optional name suffix for its writer and worker threads, and fix signature of the Twitch plugin's subclassnameargument toHLSStream, so it can be passed to its readerMuxedHLSStreamset the "audio" suffix for all audio substreams#6550 (comment)
After this has been merged, I will add the thread name to the default logformat for the trace log level.
The
FFMPEGMuxerclass has not been touched. Thecopy_to_pipethreads already have a unique name, and the thread pool that's used for concurrently closing the substreams is not important. The whole class needs to be rewritten anyway, so there's no reason to modify it now.The only plugin that needed an update was Twitch, because the constructor of the
HLSStreamReadersubclass was modified, and the signatures didn't match anymore. Other plugins that subclass the HLS reader were fine. Since this is not a public interface, I don't care about 3rd party plugins.Unmuxed HLS
Worker and writer+children are now properly named
Muxed HLS
Threads of the audio substreams have the "audio" name suffix
DASH
Worker and writer+children have unique names, including "video"/"audio" name suffixes.