cache: rewrite and improve cache file I/O #6568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
bastimeyer
force-pushed
the
cache/io-and-atomicity
branch
2 times, most recently
from
5443780 to
1114b7e
Compare
- Schedule cache file writes instead of writing immediately when pruning data on get() or when setting/pruning data on set(): Use a write debounce timer of 3s and also add an `atexit` callback - Keep a dirty state and prevent unnecessary writes - Don't ignore cache file loading errors and instead log a warning msg - Always set cache file encoding to UTF-8 when reading or writing - Refactor cache file writing logic, use higher level stdlib APIs, and log write errors instead of raising some of them
bastimeyer
force-pushed
the
cache/io-and-atomicity
branch
from
1114b7e to
16c190f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a write debounce timer of 3s and also add an
atexitcallbackRef #6501
This doesn't fix the data structure issues pointed out in #6501, but it should already be an improvement.
One thing I will have to take a look at before merging (when I get the time) is checking on Windows in regards to the file encoding. Previously, no file encoding was set when reading or writing, which means on Windows it defaults to
iso-8859-15or whatever else the system is using. JSON data is always encoded as UTF-8, but I don't know how that affects the overall file encoding, so this might break loading existing cache files.