Skip to content

plugins.twitch: fix clips validation schema #6570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bastimeyer
Copy link
Member

Fixes #6569

$ ./script/test-plugin-urls.py twitch -m -r CHANNELNAME ESL_DOTA2
:: https://clips.twitch.tv/GoodEndearingPassionfruitPMSTwin-QfRLYDPKlscgqt-4
::  360p30, 480p30, 720p60, 1080p60, worst, best
::   {'id': '1230765715', 'author': 'LIRIK', 'category': 'Pax Dei', 'title': 'Lirik loves Pax Dei'}
:: https://player.twitch.tv/?parent=twitch.tv&channel=ESL_DOTA2
::  audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '322953723388', 'author': 'ESL_DOTA2', 'category': 'Dota 2', 'title': 'HIGHLIGHTS: NIGMA Galaxy vs AURORA - DreamLeague Season 26'}
:: https://player.twitch.tv/?parent=twitch.tv&video=1963401646
::  audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '1963401646', 'author': 'dota2ti', 'category': 'Dota 2', 'title': 'LGD Gaming vs Gaimin Gladiators [0-0] - TI 12 LOWER BRACKET FINAL'}
:: https://player.twitch.tv/?parent=twitch.tv&video=1963401646&t=1h23m45s
::  audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '1963401646', 'author': 'dota2ti', 'category': 'Dota 2', 'title': 'LGD Gaming vs Gaimin Gladiators [0-0] - TI 12 LOWER BRACKET FINAL'}
:: https://twitch.tv/papaplatte/clip/SmellyDeadMomBloodTrail-WWr5gMxd0pe0BAge
::  360p30, 480p30, 1080p60, worst, best
::   {'id': '2105975528', 'author': 'Papaplatte', 'category': 'GeoGuessr', 'title': 'fan moment'}
:: https://www.twitch.tv/ESL_DOTA2
::  audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '322953723388', 'author': 'ESL_DOTA2', 'category': 'Dota 2', 'title': 'HIGHLIGHTS: NIGMA Galaxy vs AURORA - DreamLeague Season 26'}
:: https://www.twitch.tv/ESL_DOTA2/
::  audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '322953723388', 'author': 'ESL_DOTA2', 'category': 'Dota 2', 'title': 'HIGHLIGHTS: NIGMA Galaxy vs AURORA - DreamLeague Season 26'}
:: https://www.twitch.tv/ESL_DOTA2/?
::  audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '322953723388', 'author': 'ESL_DOTA2', 'category': 'Dota 2', 'title': 'HIGHLIGHTS: NIGMA Galaxy vs AURORA - DreamLeague Season 26'}
:: https://www.twitch.tv/ESL_DOTA2?
::  audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '322953723388', 'author': 'ESL_DOTA2', 'category': 'Dota 2', 'title': 'HIGHLIGHTS: NIGMA Galaxy vs AURORA - DreamLeague Season 26'}
:: https://www.twitch.tv/clip/GoodEndearingPassionfruitPMSTwin-QfRLYDPKlscgqt-4
::  360p30, 480p30, 720p60, 1080p60, worst, best
::   {'id': '1230765715', 'author': 'LIRIK', 'category': 'Pax Dei', 'title': 'Lirik loves Pax Dei'}
:: https://www.twitch.tv/dota2ti/v/1963401646
::  audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '1963401646', 'author': 'dota2ti', 'category': 'Dota 2', 'title': 'LGD Gaming vs Gaimin Gladiators [0-0] - TI 12 LOWER BRACKET FINAL'}
:: https://www.twitch.tv/dota2ti/video/1963401646
::  audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '1963401646', 'author': 'dota2ti', 'category': 'Dota 2', 'title': 'LGD Gaming vs Gaimin Gladiators [0-0] - TI 12 LOWER BRACKET FINAL'}
:: https://www.twitch.tv/lirik/clip/GoodEndearingPassionfruitPMSTwin-QfRLYDPKlscgqt-4
::  360p30, 480p30, 720p60, 1080p60, worst, best
::   {'id': '1230765715', 'author': 'LIRIK', 'category': 'Pax Dei', 'title': 'Lirik loves Pax Dei'}
:: https://www.twitch.tv/videos/1963401646
::  audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '1963401646', 'author': 'dota2ti', 'category': 'Dota 2', 'title': 'LGD Gaming vs Gaimin Gladiators [0-0] - TI 12 LOWER BRACKET FINAL'}
:: https://www.twitch.tv/videos/1963401646?t=1h23m45s
::  audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
::   {'id': '1963401646', 'author': 'dota2ti', 'category': 'Dota 2', 'title': 'LGD Gaming vs Gaimin Gladiators [0-0] - TI 12 LOWER BRACKET FINAL'}

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Jun 20, 2025
@bastimeyer bastimeyer merged commit 31ae9f8 into streamlink:master Jun 20, 2025
23 checks passed
@bastimeyer bastimeyer deleted the plugins/twitch/fix-clips-schema branch June 20, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins.twitch: Some Twitch clips return "No playable streams found" even though they exist
1 participant