Skip to content

feat(kit): InputYear refactor to new Textfield #11258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(kit): InputYear refactor to new Textfield #11258

wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

@splincode splincode commented Jul 7, 2025 •
edited
Loading

Fixes #11257

@Copilot Copilot AI review requested due to automatic review settings July 7, 2025 10:41
@splincode splincode requested a review from a team as a code owner July 7, 2025 10:41
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team July 7, 2025 10:41
@splincode splincode marked this pull request as draft July 7, 2025 10:41
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 7, 2025 •
edited
Loading

Failed tests ❌

Before (main) ← Diff → After (local)

tests-demo-demo.pw-Demo-components-input-year-chromium-retry2/components-input-year/1.ltr.diff.png
tests-demo-demo.pw-Demo-components-input-year-chromium-retry2/components-input-year/1.rtl.diff.png
tests-demo-demo.pw-Demo-components-input-year-chromium-retry2/components-input-year/2.ltr.diff.png
tests-demo-demo.pw-Demo-components-input-year-chromium-retry2/components-input-year/2.rtl.diff.png

(updated for commit 444ee34)

Copilot
Copilot AI reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR deprecates the original InputYear component by moving it to an input-year-legacy folder, updating routes, docs, and tests to point to the legacy path, and adding a deprecation notice.

  • Added a DemoRoute.InputYearLegacy entry and updated all navigation to use it.
  • Updated the legacy component’s template to show a deprecation notification linking to the new component.
  • Adjusted pages configuration and Playwright tests to reference the legacy route.

Reviewed Changes

Copilot reviewed 6 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
projects/demo/src/modules/components/input-year-legacy/index.ts Imported DemoRoute and exposed routes for the deprecation link
projects/demo/src/modules/components/input-year-legacy/index.html Changed header and added a deprecation notification
projects/demo/src/modules/app/pages.ts Updated sidebar title to mark deprecation and point to legacy route
projects/demo/src/modules/app/demo-routes.ts Added InputYearLegacy path under /legacy/input-year
projects/demo/src/modules/app/app.routes.ts Switched the route and component import to input-year-legacy
projects/demo-playwright/tests/legacy/input-year/input-year.pw.spec.ts Updated tests to navigate to the legacy route
Comments suppressed due to low confidence (3)

projects/demo/src/modules/app/pages.ts:709

  • [nitpick] Using an emoji in the title may not align with UI standards; consider 'InputYear (Legacy)' for clear and consistent deprecation labeling.
                title: 'InputYear ⛔',

projects/demo/src/modules/app/app.routes.ts:535

  • [nitpick] The route title should reflect legacy status to avoid confusion; e.g., change to 'InputYear (Legacy)'.
        title: 'InputYear',

projects/demo-playwright/tests/legacy/input-year/input-year.pw.spec.ts:6

  • Update the test suite name to 'InputYearLegacy' to accurately reflect that these are legacy component tests.
test.describe('InputYear', () => {

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 7, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 444ee34

Command Status Duration Result
nx run-many --target test --all --output-style=... ✅ Succeeded 5m 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-25 12:18:21 UTC

@codecov Codecov
Copy link

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.65854% with 19 lines in your changes missing coverage. Please review.

Project coverage is 62.94%. Comparing base (0bcf1bf) to head (a6ca0da).

Files with missing lines Patch % Lines
projects/kit/components/input-year/input-year.ts 44.82% 16 Missing ⚠️
...ts/kit/components/input-year/input-year.options.ts 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11258      +/-   ##
==========================================
- Coverage   62.97%   62.94%   -0.03%     
==========================================
  Files        1338     1341       +3     
  Lines       18388    18429      +41     
  Branches     3015     2931      -84     
==========================================
+ Hits        11579    11601      +22     
- Misses       6212     6368     +156     
+ Partials      597      460     -137
Flag Coverage Δ
summary 62.94% <53.65%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 444ee34):

https://taiga-previews-demo--pr11258-splincode-input-year-demo-byyjilcu.web.app

(expires Sat, 26 Jul 2025 11:53:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@bundlemon BundleMon
Copy link

bundlemon bot commented Jul 7, 2025 •
edited
Loading

BundleMon

Files updated (2)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 347.89KB (+489B +0.14%) +10%
✅ demo/browser/runtime.(hash).js
 52.59KB (+65B +0.12%) +10%
Unchanged files (3)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 260.95KB +10%
✅ demo/browser/styles.(hash).css
 21.38KB +10%
✅ demo/browser/polyfills.(hash).js
 11.16KB +10%

Total files change +554B +0.08%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 9.58MB (+29.75KB +0.3%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025 •
edited
Loading

Playwright test results

failed  13 failed
passed  1234 passed
flaky  1 flaky
skipped  3 skipped

Details

report  Open report ↗︎
stats  1251 tests across 77 suites
duration  13 minutes, 15 seconds
commit  444ee34

Failed tests

chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/input-year
chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /legacy/input-year
chromium › tests/deep/deep-toggle.pw.spec.ts › Deep / Toggle › /components/input-year
chromium › tests/deep/deep-toggle.pw.spec.ts › Deep / Toggle › /legacy/input-year
chromium › tests/demo/demo.pw.spec.ts › Demo › /components/input-year
chromium › tests/demo/demo.pw.spec.ts › Demo › /legacy/input-year
chromium › tests/legacy/input-year/input-year.pw.spec.ts › InputYear › Does not allow incorrect year entry › 12345 => 1234
chromium › tests/legacy/input-year/input-year.pw.spec.ts › InputYear › Does not allow incorrect year entry › 2040 => 2020
chromium › tests/legacy/input-year/input-year.pw.spec.ts › InputYear › Does not allow incorrect year entry › 0000 => blur => 0
chromium › tests/legacy/input-year/input-year.pw.spec.ts › InputYear › Does not allow incorrect year entry › 0040 => blur => 40
chromium › tests/legacy/input-year/input-year.pw.spec.ts › InputYear › Value validation on blur › can not be less than min
chromium › tests/legacy/input-year/input-year.pw.spec.ts › InputYear › need select date from dropdown › empty input => select date via calendar => new date inside text field
chromium › tests/legacy/input-year/input-year.pw.spec.ts › InputYear › need select date from dropdown › type 2020 => select new date via calendar => new date inside text field

Flaky tests

chromium › tests/kit/line-clamp/line-clamp.pw.spec.ts › LineClamp › do not close after click in hint area

Skipped tests

chromium › tests/addon-mobile/mobile-dropdown/mobile-dropdown-with-textfield.pw.spec.ts › DropdownMobile for textfields › with legacy select
chromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Esc -> Hosted Dropdown
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › non-erasable minus (as [prefix]) for [max] <= 0 › forbids to enter more minuses

@splincode splincode force-pushed the splincode/input-year branch 3 times, most recently from 39944d7 to a0f2923 Compare July 7, 2025 14:01
@splincode splincode changed the title chore: move input-year to input-year-legacy feat(kit): InputYear refactor to new Textfield Jul 7, 2025
@splincode splincode marked this pull request as ready for review July 7, 2025 14:02
@splincode splincode force-pushed the splincode/input-year branch from a0f2923 to fd3e155 Compare July 7, 2025 14:04
waterplea
waterplea reviewed Jul 8, 2025
View reviewed changes
@splincode splincode force-pushed the splincode/input-year branch 2 times, most recently from a85cb85 to 087b1e0 Compare July 8, 2025 13:53
waterplea
waterplea reviewed Jul 11, 2025
View reviewed changes
@splincode splincode force-pushed the splincode/input-year branch 3 times, most recently from 91e7334 to 68565a1 Compare July 14, 2025 06:35
@splincode splincode force-pushed the splincode/input-year branch 4 times, most recently from cda8916 to 7b19cf4 Compare July 21, 2025 12:32
vladimirpotekhin
vladimirpotekhin requested changes Jul 21, 2025
View reviewed changes
nsbarsukov
nsbarsukov reviewed Jul 21, 2025
View reviewed changes
nsbarsukov
nsbarsukov reviewed Jul 21, 2025
View reviewed changes
@vladimirpotekhin vladimirpotekhin self-requested a review July 21, 2025 13:12
@splincode splincode force-pushed the splincode/input-year branch 4 times, most recently from a66c45e to 1173361 Compare July 21, 2025 13:45
nsbarsukov
nsbarsukov reviewed Jul 21, 2025
View reviewed changes
@vladimirpotekhin vladimirpotekhin self-requested a review July 21, 2025 14:59
@splincode splincode force-pushed the splincode/input-year branch 3 times, most recently from 0a0ce31 to e7324a3 Compare July 22, 2025 11:33
nsbarsukov
nsbarsukov reviewed Jul 23, 2025
View reviewed changes
@splincode splincode force-pushed the splincode/input-year branch from e7324a3 to 85e2fbc Compare July 23, 2025 13:33
@nsbarsukov nsbarsukov self-requested a review July 24, 2025 09:28
nsbarsukov
nsbarsukov reviewed Jul 24, 2025
View reviewed changes
@nsbarsukov nsbarsukov self-requested a review July 24, 2025 09:43
@splincode splincode force-pushed the splincode/input-year branch 3 times, most recently from f81ef39 to 6b28ce5 Compare July 25, 2025 11:48
@splincode splincode force-pushed the splincode/input-year branch from 6b28ce5 to 444ee34 Compare July 25, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

Copilot code review Copilot Copilot left review comments

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

Requested changes must be addressed to merge this pull request.

Assignees

@splincode splincode

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 - InputYear
4 participants
@splincode @nsbarsukov @waterplea @vladimirpotekhin