Skip to content

feat(kit): Drawer support safe-area top/bottom #11296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 29, 2025
Merged

feat(kit): Drawer support safe-area top/bottom #11296

merged 5 commits into from
Jul 29, 2025

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Jul 11, 2025 •
edited
Loading

Partially solved #10963

BEFORE

image image

AFTER

image image

@mdlufy mdlufy requested a review from a team as a code owner July 11, 2025 06:10
@mdlufy mdlufy requested review from MarsiBarsi, waterplea, nsbarsukov and vladimirpotekhin and removed request for a team July 11, 2025 06:10
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 11, 2025 •
edited by github-actions bot
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 11, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b84fffc

Command Status Duration Result
nx run-many --target test --all --output-style=... ✅ Succeeded 2m 17s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-28 13:18:12 UTC

@codecov Codecov
Copy link

codecov bot commented Jul 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.97%. Comparing base (e6f9a42) to head (d148af5).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11296      +/-   ##
==========================================
- Coverage   62.98%   62.97%   -0.02%     
==========================================
  Files        1335     1338       +3     
  Lines       18346    18388      +42     
  Branches     2832     2972     +140     
==========================================
+ Hits        11556    11579      +23     
+ Misses       6481     6293     -188     
- Partials      309      516     +207
Flag Coverage Δ
summary 62.97% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit b84fffc):

https://taiga-previews-demo--pr11296-drawer-safe-area-demo-ga3akisg.web.app

(expires Tue, 29 Jul 2025 12:30:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@bundlemon BundleMon
Copy link

bundlemon bot commented Jul 11, 2025 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 347.44KB (+15B 0%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 260.83KB +10%
✅ demo/browser/runtime.(hash).js
 52.52KB +10%
✅ demo/browser/styles.(hash).css
 21.38KB +10%
✅ demo/browser/polyfills.(hash).js
 11.16KB +10%

Total files change +12B 0%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 9.55MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025 •
edited
Loading

Playwright test results

passed  1245 passed
skipped  3 skipped

Details

report  Open report ↗︎
stats  1248 tests across 77 suites
duration  17 minutes, 30 seconds
commit  b84fffc

Skipped tests

chromium › tests/addon-mobile/mobile-dropdown/mobile-dropdown-with-textfield.pw.spec.ts › DropdownMobile for textfields › with legacy select
chromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Esc -> Hosted Dropdown
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › non-erasable minus (as [prefix]) for [max] <= 0 › forbids to enter more minuses

waterplea
waterplea reviewed Jul 11, 2025
View reviewed changes
@mdlufy mdlufy requested a review from waterplea July 11, 2025 22:44
mdlufy
mdlufy commented Jul 12, 2025
View reviewed changes
waterplea
waterplea requested changes Jul 16, 2025
View reviewed changes
@mdlufy mdlufy force-pushed the drawer-safe-area branch from d148af5 to b84fffc Compare July 28, 2025 12:21
@mdlufy mdlufy requested a review from waterplea July 28, 2025 12:24
@mdlufy mdlufy merged commit b796cb7 into main Jul 29, 2025
26 checks passed
@mdlufy mdlufy deleted the drawer-safe-area branch July 29, 2025 08:41
@taiga-family-bot taiga-family-bot mentioned this pull request Jul 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

Assignees

@mdlufy mdlufy

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdlufy @waterplea @splincode @taiga-family-bot